Skip to content

deps: update libffi to 3.6.0#64040

Open
nodejs-github-bot wants to merge 3 commits into
mainfrom
actions/truetools-update-libffi
Open

deps: update libffi to 3.6.0#64040
nodejs-github-bot wants to merge 3 commits into
mainfrom
actions/truetools-update-libffi

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

This is an automated update of libffi to 3.6.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. ffi Issues and PRs related to experimental Foreign Function Interface support. labels Jun 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/ffi
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 21, 2026
@ShogunPanda
fixup
d658f44 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
@ShogunPanda ShogunPanda mentioned this pull request Jun 21, 2026
Closed
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/74321/

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 21, 2026
@github-actions

github-actions Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95

aduh95 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Let's fast-track to include it in the next 26.x release, which I'd like to be able to prepare today

@aduh95

aduh95 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Related compilation failure on AIX and Windows

../deps/libffi/src/powerpc/ffi_darwin.c:1456:14: error: use of undeclared identifier 'PPC_LD_NONE'
 1456 |       return PPC_LD_NONE;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1458:14: error: use of undeclared identifier 'PPC_LD_F32'
 1458 |       return PPC_LD_F32;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1460:14: error: use of undeclared identifier 'PPC_LD_F64'
 1460 |       return PPC_LD_F64;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1463:14: error: use of undeclared identifier 'PPC_LD_F128'
 1463 |       return PPC_LD_F128;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1466:14: error: use of undeclared identifier 'PPC_LD_U8'
 1466 |       return PPC_LD_U8;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1468:14: error: use of undeclared identifier 'PPC_LD_S8'
 1468 |       return PPC_LD_S8;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1470:14: error: use of undeclared identifier 'PPC_LD_U16'
 1470 |       return PPC_LD_U16;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1472:14: error: use of undeclared identifier 'PPC_LD_S16'
 1472 |       return PPC_LD_S16;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1474:14: error: use of undeclared identifier 'PPC_LD_U32'
 1474 |       return PPC_LD_U32;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1477:14: error: use of undeclared identifier 'PPC_LD_S32'
 1477 |       return PPC_LD_S32;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1479:14: error: use of undeclared identifier 'PPC_LD_PTR'
 1479 |       return PPC_LD_PTR;
      |              ^
../deps/libffi/src/powerpc/ffi_darwin.c:1482:14: error: use of undeclared identifier 'PPC_LD_I64'
 1482 |       return PPC_LD_I64;
      |              ^
2 warnings and 12 errors generated.

Renegade334
Renegade334 reviewed Jun 21, 2026
View reviewed changes
Comment thread deps/libffi/libffi.gyp

@Renegade334 Renegade334 Jun 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an awful lot of changes to the build infrastructure here. Is this definitely the only change we need?

Comment thread deps/libffi/libffi.gyp
@aduh95 aduh95 mentioned this pull request Jun 21, 2026
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/74334/

@Renegade334 Renegade334 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 left review comments

@aduh95 aduh95 aduh95 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 72 hours to land. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nodejs-github-bot @aduh95 @Renegade334 @ShogunPanda